Avoiding having github javascript executed
This is kind of a reopening of #381 .
In patchmon 1.3.7, when I connect to the server, I see the a fleeting github status widget and after a fraction of a second the new login screen is shown, now without the github widget. Sounds like the widget is still there, just hidden.
I also see, thanks to the noScript browser extension that some connections to github are being made.
Would it be possible to remove all the code that executes javascript coming from github when the option to show the github version in the settings is disabled? As mentioned in #381, one of the reasons of self-hosting patchmon is to ensure that only your own domains are being used.
The github icon at the right top corner in patchmon (after logged in) is still fine. That connects to github only when the user explicitly wants it.
2 Comments
Hey @cquike - I will go through this and make a separate toggle for disabling outgoing connections.
There are a few different types of connections that are going out from PatchMon for various reasons but I'll go through it and see what I can do in order to make it less noisy as possible.
The only thing that comes to mind that would still be needed is the mechanism of checking current server version against the release that github has on latest, however this can be left manual and the automation queue in BullMQ can be disabled for this.
Leave it to me and I will sort this out for us :)
Great. Thanks for looking into this!